Skip to content

feat(cli): add sync remote subcommand#278

Merged
Brooooooklyn merged 4 commits intomainfrom
10-30-feat_cli_add_sync_remote_subcommand
Oct 30, 2025
Merged

feat(cli): add sync remote subcommand#278
Brooooooklyn merged 4 commits intomainfrom
10-30-feat_cli_add_sync_remote_subcommand

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn commented Oct 30, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 30, 2025 06:25
@Brooooooklyn Graphite App
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Oct 30, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new sync-remote tool command that synchronizes dependencies from the rolldown and rolldown-vite repositories by cloning them locally and merging their pnpm workspace configurations. The implementation includes intelligent version merging logic for semver ranges.

Key changes:

  • New sync-remote-deps.ts module with git repository cloning and pnpm workspace merging functionality
  • Added dependencies: @std/yaml, semver, @types/semver, @oxc-node/cli, and @oxc-node/core
  • Updated tool command dispatcher to include the new sync-remote subcommand

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Added catalog entries for new dependencies required by the sync-remote tool
pnpm-lock.yaml Lockfile updates reflecting the new dependencies
packages/tools/src/sync-remote-deps.ts New module implementing git repository syncing and pnpm workspace merging logic
packages/tools/src/index.ts Added sync-remote subcommand handling and updated help text
packages/tools/package.json Added new devDependencies and dependencies for YAML parsing, semver handling, and oxc-node
.npmrc Configured JSR registry for @jsr scoped packages
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/tools/package.json Outdated
Comment thread packages/tools/src/index.ts
@Brooooooklyn Brooooooklyn force-pushed the 10-30-feat_cli_add_sync_remote_subcommand branch from a9fbfc0 to 6b3d545 Compare October 30, 2025 06:27
@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Oct 30, 2025

💡 Codex Review

vite-plus/packages/tools/src/index.ts

Lines 1 to 3 in a9fbfc0

import { replaceFileContent } from './replace-file-content.js';
import { snapTest } from './snap-test.js';
import { syncRemote } from './sync-remote-deps.js';

P1 Badge Restore TypeScript import paths

The CLI entry now imports replace-file-content and snap-test using .js extensions. However, bin.js loads index.ts through @oxc-node/core/register, which transpiles .ts modules on demand. With the extension changed to .js, Node attempts to resolve replace-file-content.js and snap-test.js files that are not generated anywhere in the repository, so any invocation of the tool binary will throw ERR_MODULE_NOT_FOUND before dispatching the subcommand. The imports should point back to the .ts sources (or the build should generate .js files).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI review requested due to automatic review settings October 30, 2025 06:36
@Brooooooklyn Brooooooklyn force-pushed the 10-30-feat_cli_add_sync_remote_subcommand branch from 6b3d545 to 93baf85 Compare October 30, 2025 06:36
Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/tools/package.json Outdated
Comment thread packages/tools/src/index.ts Outdated
fengmk2
fengmk2 reviewed Oct 30, 2025
View reviewed changes
Comment thread pnpm-workspace.yaml
branchseer
branchseer reviewed Oct 30, 2025
View reviewed changes
Comment thread packages/tools/src/index.ts Outdated
@Brooooooklyn
Update packages/tools/src/index.ts
6b4be06 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: LongYinan <lynweklm@gmail.com>
Copilot AI review requested due to automatic review settings October 30, 2025 06:50
Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/tools/src/sync-remote-deps.ts
@Brooooooklyn Graphite App
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Oct 30, 2025 •
edited
Loading

Merge activity

  • Oct 30, 7:05 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 30, 7:05 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 9ceae3b into main Oct 30, 2025
16 checks passed
@Brooooooklyn Brooooooklyn deleted the 10-30-feat_cli_add_sync_remote_subcommand branch October 30, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@branchseer branchseer branchseer approved these changes

@fengmk2 fengmk2 Awaiting requested review from fengmk2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Brooooooklyn @fengmk2 @branchseer